adding whole-project loading#5002
Conversation
Saizan
force-pushed
the
hie-bios-0.20
branch
2 times, most recently
from
d0b01cc to
b29e37a
Compare
|
@fendor let me know if you have a better field name than |
| <*> o .:? "sessionLoading" .!= sessionLoading defValue | ||
| <*> loadingPref o | ||
| <*> o .:? "linkSourceTo" .!= linkSourceTo defValue |
There was a problem hiding this comment.
We should definitely not deprecate sessionLoading without warning first. :) Happy to make sure that the next HLS announcement on the Haskell blog includes it.
|
Can we open an issue proposing what the changes to HLS are? |
fendor
left a comment
fendor
left a comment
There was a problem hiding this comment.
Changes look good to me, primarily a question of UX and naming
|
Created issue #5005 to document design |
There was a problem hiding this comment.
Good work so far @Saizan, I'm seeing a couple of things that I'd like you to clarify:
-
There seems to be both
needed-onlyandonly-needed, is that desired? We should probably stick withmulti: needed-only. -
You seem to have introduced the double usage of
multipleComponents(full words, plural) andmultiComponent(abbreviated, singular). Please stay withmultipleComponents:
[ show @String old_value ++ " (deprecated)"
==> | old_value <- ["singleComponent","multiComponent"]
]- I feel like there is a similar disparity between "session loading" and "component loading" but maybe I'm wrong?
|
@Kleidukos thanks for catching that, decided to give a name to these strings, see last commit. |
3 participants
Updates hls to hie-bios 0.20 and takes advantage of its new LoadMode to add "whole project" components loading: loads all components specified in the cradle from the start, regardless of which files are open.
TODO: